Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove werkzeug dependency in 1.4.latest branch #8964

Closed
wants to merge 2 commits into from
Closed

Remove werkzeug dependency in 1.4.latest branch #8964

wants to merge 2 commits into from

Conversation

buck-omni
Copy link

@buck-omni buck-omni commented Nov 1, 2023 •
edited
Loading

1.4.latest patch for #8941

Problem

Werkzeug appears to be an unused dependency

Solution

Remove it as a dependency

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 1, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @b-ryan

@dbeatty10
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Nov 1, 2023
@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 1, 2023

The cla-bot has been summoned, and re-checked this pull request!

@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Nov 1, 2023
@buck-omni
Copy link
Author

adding changelog momentarily...

buck-omni pushed a commit to buck-omni/dbt-core that referenced this pull request Nov 1, 2023
@b-ryan
changelog entry for dbt-labs#8964 dbt-labs#8965
42f5eb7
@dbeatty10 dbeatty10 added the community This PR is from a community member label Apr 3, 2024
@KaneMorgan KaneMorgan mentioned this pull request Oct 28, 2024
Closed
3 tasks
@graciegoheen
Copy link
Contributor

Hi! Thanks so much for opening this up. Given that 1.4 is "End of Life", I'm going to close this out since we don't release patches of old versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes community This PR is from a community member ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@buck-omni @dbeatty10 @graciegoheen @b-ryan